• Share
    • Twitter
    • LinkedIn
    • Facebook
    • Email
  • Feedback
  • Edit
Show / Hide Table of Contents

View and incorporate feedback on PR

Some tooltip text!
• 3 minutes to read
 • 3 minutes to read

View feedback

  1. Go to the repository and click Pull requests.

  2. Select a PR from the list.

  3. Select the Conversation tab.

  4. Scroll to a review and click View changes.

    GitHub PR conversation view changes -screenshot

For each remark, you can choose to reply with a comment, commit the suggested changes, or edit the file directly.

Commit suggested changes

  1. On the Files changed tab, scroll to the first suggestion.

  2. Click Commit suggestion.

    GitHub PR commit changes -screenshot

  3. Enter a short message and click Commit changes.

Tip

To apply multiple suggestions, optionally click Add suggestion to batch in step 2. This will group them into a single commit rather than one commit per accepted change.

Edit file on GitHub

If you edited a file on GitHub, a branch was created at the same time you created the PR.

GitHub create patch -screenshot

To update this file again on that branch:

  1. When viewing the PR, select the Files changed tab.

  2. Click the three dots above the changed file and select Edit file.

    GitHub edit file in PR -screenshot

  3. The branch name should match the patch you created.

    GitHub edit file in patch -screenshot

  4. Revise the file as requested in the PR review.

  5. Commit the file, selecting the option to commit directly to the patch branch.

    GitHub commit to patch -screenshot

Alternatively, browse to the file manually

  1. When viewing the PR, click the two squares below the PR header to copy the branch name:

    GitHub copy patch name -screenshot

  2. Select the Files changed tab and note or copy the file path.

    GitHub copy path -screenshot

  3. Select the Code tab on the main menu.

  4. Select your PR branch.

    GitHub select branch -screenshot

  5. Navigate the folders till you locate the file.

  6. Click the pencil icon to edit and revise as necessary.

  7. Commit the file, selecting the option to commit directly to the patch branch.

Check out and edit PR branch locally

Note the issue number of the PR.

  • If you already have the branch locally, pull to get the latest updates.

  • If you have a clone of the repo, pull on main, then switch to the branch associated with the PR.

  • Otherwise: On the Conversation tab, click Code and select how to check out the PR.

    GitHub PR checkout locally -screenshot

Then revise and commit the changes to the branch. After pushing, the PR on GitHub is updated with the changes.

© SuperOffice. All rights reserved.
SuperOffice |  Community |  Release Notes |  Privacy |  Site feedback |  Search Docs |  About Docs |  Contribute |  Back to top